Add label for differentiating OCP and HyperShift archives #196
+260
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "archive" label allows us to differentiate the type of archive
we are handling. Since that information is known only after extracting
the archive, the following changes have been implemented:
- "archive" label was added to StatsWatcher
- The new label is only used in metrics that are updated after the
extraction of the archive:
- ccx_consumer_extracted_total
- ccx_engine_processed_total
- ccx_published_total
- ccx_failures_total
- ccx_download_duration_seconds and ccx_process_duration_seconds if
there was a failure during download or processing of the archive
- ccx_publish_duration_seconds
- ccx_engine_processed_timeout_total
- The label's value is reset to 'ocp' everytime a new archive is
received (when `on_recv` is fired).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 84.73% 84.69% -0.05%
==========================================
Files 33 33
Lines 1055 1078 +23
==========================================
+ Hits 894 913 +19
- Misses 161 165 +4 ☔ View full report in Codecov by Sentry. |
epapbak
force-pushed
the
CCXDEV-12520
branch
2 times, most recently
from
ab579a5 to
7b685f7
Compare
epapbak
requested review from
Bee-lee,
joselsegura,
matysek,
JiriPapousek,
juandspy and
Jakub007d
as code owners
joselsegura
approved these changes
Apr 17, 2024
juandspy
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "archive" label allows us to differentiate the type of archive we are handling. Since that information is known only after extracting the archive, the following changes have been implemented:
on_recvis fired).Fixes CCXDEV-12520
Type of change
Testing steps
Updated UTs
Checklist
pre-commit run -apasses